Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34991 )
Change subject: arch/x86: Include stack_top region into postcar_frame
......................................................................
Patch Set 4:
@Aaron, do you think this is more specific to APL as you have implemented platform_segment_loaded() in apl/car.c ?
/* Bail out if loaded program segment does not lie in CAR region. */
if (!start_car_check && !end_car_check)
return;
That's what apollolake/car.c currently has, maybe you have followup work to change it, but with pcf->stack in CBMEM this commit does not do anything?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34991
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9279bbd66be0ad309bdabbbb90bf59c6f5967c47
Gerrit-Change-Number: 34991
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 27 Aug 2019 11:58:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment