Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50239 )
Change subject: soc/amd/cezanne: populate some FSP-M UPDs
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/cezanne/romstage.c:
https://review.coreboot.org/c/coreboot/+/50239/comment/4cd64a9b_e874ba31
PS2, Line 19: 1
Is this to handle the case of legacy IO?
no. in the mmio case the spacing between the registers might be either 1 or 4 bytes. see src/drivers/uart/uart8250mem.c
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50239
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I81a812662f921d0bf8d436238d338b6a1fa6a9ee
Gerrit-Change-Number: 50239
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Tue, 02 Feb 2021 22:01:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment