build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34447 )
Change subject: soc/intel/common: Set controller state to active in uart init ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34447/2/src/soc/intel/common/block/... File src/soc/intel/common/block/uart/uart.c:
https://review.coreboot.org/c/coreboot/+/34447/2/src/soc/intel/common/block/... PS2, Line 36: static void uart_lpss_init(uintptr_t baseaddr,struct device *dev) space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/34447/2/src/soc/intel/common/block/... PS2, Line 39: lpss_set_power_state(dev, STATE_D0); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/34447/2/src/soc/intel/common/block/... PS2, Line 39: lpss_set_power_state(dev, STATE_D0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/34447/2/src/soc/intel/common/block/... PS2, Line 87: uart_lpss_init(baseaddr,device); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/34447/2/src/soc/intel/common/block/... PS2, Line 230: uart_lpss_init(base,dev); space required after that ',' (ctx:VxV)