Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61390 )
Change subject: soc/mediatek/mt8186: Add register protect control for MT6366 ......................................................................
Patch Set 1:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61390/comment/9e47bfb2_4c5e788d PS1, Line 10: the
https://review.coreboot.org/c/coreboot/+/61390/comment/e68396a7_9e668451 PS1, Line 11: after the init setting is : done afterward
https://review.coreboot.org/c/coreboot/+/61390/comment/cd32f9db_6c41c113 PS1, Line 15: setting set
File src/soc/mediatek/mt8186/mt6366.c:
https://review.coreboot.org/c/coreboot/+/61390/comment/3b7c5f89_448d1237 PS1, Line 780: static void mt6366_protect_control(bool en_protect) Please call this function from wk_power_down_seq() and pmic_set_vddq_vol().
https://review.coreboot.org/c/coreboot/+/61390/comment/9ee7a9ac_f7101b8c PS1, Line 782: struct pmic_setting tma_setting = {0x3A8, 0x0, 0xFFFF, 0}; : tma_setting.val = en_protect ? 0 : 0x9CA7; : : pwrap_write_field(tma_setting.addr, tma_setting.val, : tma_setting.mask, tma_setting.shift); Rewrite as
/* Write a magic number 0x9CA7 to disable protection */ pwrap_write_field(PMIC_TOP_TMA_KEY, en_protect ? 0 : 0x9CA7, 0xFFFF, 0);
The comment above is modified from wk_power_down_seq(). If that's incorrect, please fix it by yourself.