build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38165 )
Change subject: soc/intel/tigerlake: Enable VT-d and generate DMAR ACPI table ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38165/1/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi.c:
https://review.coreboot.org/c/coreboot/+/38165/1/src/soc/intel/tigerlake/acp... PS1, Line 202: if (igfx_dev && igfx_dev->enabled && gfxvtbar && gfxvten) { suspect code indent for conditional statements (8, 8)
https://review.coreboot.org/c/coreboot/+/38165/1/src/soc/intel/tigerlake/acp... PS1, Line 259: sa_get_gsm_base(), sa_get_tolud_base() -1); need consistent spacing around '-' (ctx:WxV)