Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45635 )
Change subject: vendorcode/google: add CHROMEOS_DRAM_PART_NUMBER_IN_CBI Kconfig option ......................................................................
Patch Set 21:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45635/21/src/vendorcode/google/chro... File src/vendorcode/google/chromeos/dram_part_num_override.c:
https://review.coreboot.org/c/coreboot/+/45635/21/src/vendorcode/google/chro... PS21, Line 11: UNINITIALIZED
nit: I think the names can be a little more descriptive. […]
Done
https://review.coreboot.org/c/coreboot/+/45635/21/src/vendorcode/google/chro... PS21, Line 15: int
Use the enum type? […]
Done
https://review.coreboot.org/c/coreboot/+/45635/21/src/vendorcode/google/chro... PS21, Line 26: printk
Is it intentional that this error will be printed every time mainboard_get_dram_part_num() is called […]
Yes, that was the initial behavior of routines that didn't have an ec checked status. I'll change it to only log once given you think that's sufficient.