[coreboot-gerrit] Change in coreboot[master]: util/ifdtool: Add support for Denverton Soc

[Martin Roth (Code Review)]

Attention is currently required from: Felix Singer, Jeff Daly, Mariusz Szafrański, Suresh Bellampalli, Stefan Reinauer, Vanessa Eusebio, Michal Motyl, Michael Niewöhner, Kyösti Mälkki, Patrick Rudolph.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60830 )

Change subject: util/ifdtool: Add support for Denverton Soc
......................................................................

Patch Set 13: Code-Review+2

(2 comments)

File util/ifdtool/ifdtool.h:

https://review.coreboot.org/c/coreboot/+/60830/comment/e5bd9d9f_2c3f00db 
PS13, Line 52: 	PLATFORM_ADL,
Not a big deal, but generally the preference is to make changes like reordering things in a separate commit than other code changes.  I won't ask for it here, but in the future, it's a good practice.  It just makes it more difficult to review when you not only add something, but change the order as well.

File util/ifdtool/ifdtool.c:

https://review.coreboot.org/c/coreboot/+/60830/comment/8a176a3f_1b96c4c9 
PS13, Line 718: has_gbe_region = (platform != PLATFORM_DNV);
              : 	has_ec_region = (ifd_version >= IFD_VERSION_2) && (platform != PLATFORM_DNV);
              : 	has_10gbe_0_region = (platform == PLATFORM_DNV);
              : 	has_10gbe_1_region = (platform == PLATFORM_DNV);
Would it be useful to turn these into functions or macros so that they can be called from anywhere?  If so, that can be changed in a follow-on patch, and doesn't need to be done in this one.