Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43804 )
Change subject: /soc/amd/acpi: Move ACPI IVRS generation to coreboot ......................................................................
Patch Set 11:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43804/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43804/8//COMMIT_MSG@7 PS8, Line 7: /soc/amd/acpi
soc/amd/acpi: …
Ack
https://review.coreboot.org/c/coreboot/+/43804/8//COMMIT_MSG@11 PS8, Line 11: binary.
Please do not wrap lines after sentences, if it’s not the end of a paragraph. […]
Ack
https://review.coreboot.org/c/coreboot/+/43804/8//COMMIT_MSG@14 PS8, Line 14: TEST=Boot trembyle to shell and extract and compare IVRS tables
Are they the same?
Ack
https://review.coreboot.org/c/coreboot/+/43804/8/src/include/acpi/acpi_ivrs.... File src/include/acpi/acpi_ivrs.h:
https://review.coreboot.org/c/coreboot/+/43804/8/src/include/acpi/acpi_ivrs.... PS8, Line 113: /// MMIO Offset 0x30
As far as i can tell, they are.
Done