Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35681 )
Change subject: cpu/x86/smm: Add support for long mode ......................................................................
Patch Set 13:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35681/11/src/cpu/x86/64bit/exit32.i... File src/cpu/x86/64bit/exit32.inc:
https://review.coreboot.org/c/coreboot/+/35681/11/src/cpu/x86/64bit/exit32.i... PS11, Line 42: jmp __longmode_compatibility
as this file is included by other assembly files there has to be a jmp somewhere to skip SetCodeSele […]
Done
https://review.coreboot.org/c/coreboot/+/35681/12/src/cpu/x86/64bit/exit32.i... File src/cpu/x86/64bit/exit32.inc:
https://review.coreboot.org/c/coreboot/+/35681/12/src/cpu/x86/64bit/exit32.i... PS12, Line 25: #if defined(__x86_64__)
This file should only be included if __x86_64__ is defined, so don't think you need this check.
Done
https://review.coreboot.org/c/coreboot/+/35681/12/src/cpu/x86/64bit/exit32.i... PS12, Line 55: ..
.. […]
Done