Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44039 )
Change subject: mb/google/volteer: Use device aliases
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44039/10/src/mainboard/google/volte...
File src/mainboard/google/volteer/variants/halvor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44039/10/src/mainboard/google/volte...
PS10, Line 11: # Baseboard has these on, so they must be disabled here.
Comment is not really correct for this variant.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44039
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5620004afd7fa4d50389f32dd79148960a2b2662
Gerrit-Change-Number: 44039
Gerrit-PatchSet: 10
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 09 Oct 2020 22:29:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment