Attention is currently required from: Arthur Heymans, Benjamin Doron, David Milosevic.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78284?usp=email )
Change subject: arch/arm64: Support calling a trusted monitor ......................................................................
Patch Set 15:
(2 comments)
File src/arch/arm64/smc.c:
https://review.coreboot.org/c/coreboot/+/78284/comment/d6343a3a_aa2c0355 : PS15, Line 9: inline
I don't think inline works without static: You want it to be exported at the compilation module leve […]
I don't actually see the point of this function at all. It's not different from `smc()`. Anyone who calls this can just call `smc()` directly.
Instead, I think this (`smc_call()`) should be removed and the above prototype for `smc()` (minus the `extern`) should be moved into `arch/smc.h` instead.
https://review.coreboot.org/c/coreboot/+/78284/comment/7294616d_bebd55e0 : PS15, Line 15: inline _This_ is a function that, like Arthur says, should also be `static` in addition to `inline`. This doesn't need to be output into the binary by itself because it is not going to get called by assembly. It just exists in C to make it easier to write `smc()` calls with less arguments.
This should probably also go in `arch/smc.h` instead so that other C code outside of this file could use it if they want to.