Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85151?usp=email )
Change subject: soc/intel/xeon_sp: Support _PRT reporting for domain ......................................................................
soc/intel/xeon_sp: Support _PRT reporting for domain
acpigen_write_PRT_pre_routed should support _PRT reporting for both domains and PCI root ports.
TESTED=Build and boot on intel/avenuecity CRB
_PRT will be correctly reported and IRQ routing missing error in dmesg will disappear
[ 40.406496] pcieport 0000:14:08.0: can't derive routing for PCI INT A [ 40.413799] pci 0000:17:00.0: PCI INT A: no GSI [ 40.418965] pcieport 0000:14:08.0: can't derive routing for PCI INT A [ 40.426272] ast 0000:18:00.0: PCI INT A: no GSI
Change-Id: I07b9ce7b698a0bad30f0a20998a6543101d12542 Signed-off-by: Shuo Liu shuo.liu@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/85151 Reviewed-by: Lean Sheng Tan sheng.tan@9elements.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Eric Lai ericllai@google.com Reviewed-by: yuchi.chen@intel.com --- M src/soc/intel/xeon_sp/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Eric Lai: Looks good to me, but someone else must approve build bot (Jenkins): Verified Lean Sheng Tan: Looks good to me, approved yuchi.chen@intel.com: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/xeon_sp/acpi.c b/src/soc/intel/xeon_sp/acpi.c index 0a4587c..9a3c462 100644 --- a/src/soc/intel/xeon_sp/acpi.c +++ b/src/soc/intel/xeon_sp/acpi.c @@ -202,7 +202,7 @@ uint32_t routed_dev_bitmap = 0; char *entry_count;
- if (!is_pci_bridge(br)) + if (!dev_is_active_bridge(br)) return;
const char *acpi_scope = acpi_device_path(br);