Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48943 )
Change subject: soc/amd/picasso: Add STXS and CTXS method ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48943/4/src/soc/amd/picasso/acpi.c File src/soc/amd/picasso/acpi.c:
https://review.coreboot.org/c/coreboot/+/48943/4/src/soc/amd/picasso/acpi.c@... PS4, Line 489: { i wonder if it would be useful to keep the check if gpio_num is lower than SOC_GPIO_TOTAL_PINS in the new code to avoid clobbering some unrelated registers if gpio_num is way too large