mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35506 )
Change subject: trogdor: support mbn_version 6 with python build scripts ......................................................................
Patch Set 38:
(7 comments)
https://review.coreboot.org/c/coreboot/+/35506/12/util/qualcomm/createxbl.py File util/qualcomm/createxbl.py:
https://review.coreboot.org/c/coreboot/+/35506/12/util/qualcomm/createxbl.py... PS12, Line 217: is_ext_mbn_v5 = True
a new version will be uploaded with the required fix
Done
https://review.coreboot.org/c/coreboot/+/35506/17/util/qualcomm/mbn_tools.py File util/qualcomm/mbn_tools.py:
https://review.coreboot.org/c/coreboot/+/35506/17/util/qualcomm/mbn_tools.py... PS17, Line 74: MBN_HEADER_VERSION_6 = 6 # Mbn header_version 6
Well, for a SHA size it makes sense because the reader doesn't automatically know what the size is j […]
Done
https://review.coreboot.org/c/coreboot/+/35506/17/util/qualcomm/mbn_tools.py... PS17, Line 578: if self.flash_parti_ver == MBN_HEADER_VERSION_6:
Currently, 7,8,9 and later are not supported so this will be confusing to add check like this
Done
https://review.coreboot.org/c/coreboot/+/35506/17/util/qualcomm/mbn_tools.py... PS17, Line 593: if self.flash_parti_ver == MBN_HEADER_VERSION_6:
same reply
Done
https://review.coreboot.org/c/coreboot/+/35506/17/util/qualcomm/mbn_tools.py... PS17, Line 1009: if header_version == MBN_HEADER_VERSION_5:
Equality checking here is much more sensible then comparison.
Done
https://review.coreboot.org/c/coreboot/+/35506/17/util/qualcomm/mbn_tools.py... PS17, Line 1050: global MI_PROG_BOOT_DIGEST_SIZE
Can we please change this from a global to a normal local variable (and no ALL_CAPS name)? It's only […]
Done
https://review.coreboot.org/c/coreboot/+/35506/17/util/qualcomm/mbn_tools.py... PS17, Line 2134: if header_version == MBN_HEADER_VERSION_6:
same reply as above
Done