[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8192: Do dramc software impedance calibration

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44704 )

Change subject: soc/mediatek/mt8192: Do dramc software impedance calibration
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/44704/1/src/soc/mediatek/mt8192/dra... 
File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:

https://review.coreboot.org/c/coreboot/+/44704/1/src/soc/mediatek/mt8192/dra... 
PS1, Line 3: string
> memcpy will call later, so can't remove it. […]

I think we usually want to add header files when adding the code that really uses it. Can you move this to where memcpy will be added?

https://review.coreboot.org/c/coreboot/+/44704/1/src/soc/mediatek/mt8192/dra... 
PS1, Line 6: timer.h>
> wait_us will call later, so can't remove it. […]

I think we usually want to add header files when adding the code that really uses it. Can you move this to where wait_us will be added?