Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31318 )
Change subject: soc/amd/common: Move PI refcode loader ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patch Set 3:
Patch Set 3:
Not sure why you want to move code from a already existing file into a new file? Are you planning on doing this unification? What about future Agesa version 9 (currently being developed)? Should we force Agesa 9 to use this loaders? I would rather wait Martin's opinion.
You cannot talk to me about AGESAv9. Not my choice, I would like it if you could.
From I understood AGESAv9 is such a different beast that code-sharing with AGESAv8 in coreboot proper would not make sense. And for god's sake let's finally drop agesawrapper.c!
Marshall is the one involved with AGESA v9. I still don't like creating a separate file for just moving some functions, though if you really unify all code I'll accept it makes sense. Nothing to complain on the files themselves, just the copyright date on the new file.
https://review.coreboot.org/#/c/31318/3/src/soc/amd/common/block/pi/refcode_... File src/soc/amd/common/block/pi/refcode_loader.c:
https://review.coreboot.org/#/c/31318/3/src/soc/amd/common/block/pi/refcode_... PS3, Line 4: 2017 As this is a new file (though old code), maybe 2019?