[coreboot-gerrit] Change in coreboot[master]: mb/facebook/monolith: Use serial number and UUID from VPD

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38753 )

Change subject: mb/facebook/monolith: Use serial number and UUID from VPD
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38753/1/src/mainboard/facebook/mono... 
File src/mainboard/facebook/monolith/ramstage.c:

https://review.coreboot.org/c/coreboot/+/38753/1/src/mainboard/facebook/mono... 
PS1, Line 57: 		 else
> Statements should start on a tabstop

suggest: Use same handling in smbios_system_serial_number() and smbios_system_set_uuid()

if (vpd_gets(VPD_KEY_UUID, vpd_uuid_string, UUID_STRLEN+1, VPD_RO)) {
    if (!parse_uuid(uuid, vpd_uuid_string))
    return;
}
memset(uuid, 0, UUID_LEN);
printk(BIOS_ERR, "UUID could not be read or invalid.\n");