Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39341 )
Change subject: soc/intel/tigerlake: Set dynamic pad termination for SD CMD pin
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/39341/2/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params_jsl.c:
https://review.coreboot.org/c/coreboot/+/39341/2/src/soc/intel/tigerlake/fsp...
PS2, Line 153: params->SdCardGpioCmdPadTermination = DYNAMIC_PAD_TERMINATION;
I don't see why this would be required. Coreboot is capable of configuring pad termination to be native.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39341
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1bdb2d8cf2b16cb43f39927fe616d177a9e54f48
Gerrit-Change-Number: 39341
Gerrit-PatchSet: 2
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 06 Mar 2020 21:51:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment