Peter Marheine has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48844 )
Change subject: mb/google/zork: enable wake on EC MKBP interrupts ......................................................................
mb/google/zork: enable wake on EC MKBP interrupts
The EC generates EC_MKBP_EVENT_DP_ALT_MODE_ENTERED when USB-C connections enter DP alt mode, which should wake the system from S3. The EC signals these events via falling edge on EC_AP_INT_ODL, so this GPIO should be configured as a wake source.
BUG=b:174121852 BRANCH=zork TEST=Manually-generated MKBP event (via EC console) wakes AP from S3.
Change-Id: I8100c6253e8e5cae91586c4f2f45d66c15fecc6d Signed-off-by: Peter Marheine pmarheine@chromium.org --- M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/48844/1
diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c index a2ad517..1a026e2 100644 --- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c +++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c @@ -69,8 +69,8 @@ PAD_GPI(GPIO_29, PULL_NONE), /* FCH_ESPI_EC_CS_L */ PAD_NF(GPIO_30, ESPI_CS_L, PULL_NONE), - /* EC_AP_INT_ODL (Sensor Framesync) */ - PAD_GPI(GPIO_31, PULL_NONE), + /* EC_AP_INT_ODL (mkbp interrupt) */ + PAD_WAKE(GPIO_31, PULL_NONE, EDGE_LOW, S3), /* GPIO_33 - GPIO_39: Not available */ /* NVME_AUX_RESET_L */ PAD_GPO(GPIO_40, HIGH),