Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33112 )
Change subject: Kconfig: Align kconfigs with correct stage configs
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/33112/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33112/2//COMMIT_MSG@13
PS2, Line 13: if set
?
https://review.coreboot.org/#/c/33112/2/src/Kconfig
File src/Kconfig:
https://review.coreboot.org/#/c/33112/2/src/Kconfig@173
PS2, Line 173: &&
I don't think this should be && since we can have combinations like this:
COMPRESS romstage but no verstage
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33112
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d0c31152ffa8faf62b10a6bda12c9ad2e786d94
Gerrit-Change-Number: 33112
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Fri, 31 May 2019 17:17:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment