Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35387 )
Change subject: security/vboot: Replace use of __PRE_RAM__
......................................................................
Patch Set 3:
I merged this already, but now came across this:
# When VBOOT_STARTS_IN_ROMSTAGE is selected, DRAM is already up by
# the time verstage runs.
ifneq ($(CONFIG_VBOOT_STARTS_IN_ROMSTAGE),y)
verstage-generic-ccopts += -D__PRE_RAM__
endif
We have early ChromeOS hardware with VBOOT_STARTS_IN_ROMSTAGE=y, I wonder if some of this got regressed with __PRE_RAM__ replacements? We should adjust ENV_ROMSTAGE_OR_AFTER in rules.h?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35387
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibaeda2762c733fdbe48979b635cc0cfd7ee4295d
Gerrit-Change-Number: 35387
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 14 Sep 2019 11:34:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment