build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46658 )
Change subject: soc/intel/xeon_sp: Use common cpu/intel romstage entry ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46658/1/src/soc/intel/xeon_sp/memma... File src/soc/intel/xeon_sp/memmap.c:
https://review.coreboot.org/c/coreboot/+/46658/1/src/soc/intel/xeon_sp/memma... PS1, Line 39: uintptr_t top_of_ram = (uintptr_t) cbmem_top(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/46658/1/src/soc/intel/xeon_sp/memma... PS1, Line 39: uintptr_t top_of_ram = (uintptr_t) cbmem_top(); please, no spaces at the start of a line