Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38601 )
Change subject: asus/p2b*: Declare _SB.PCI0.MBRS in DSDT ......................................................................
Patch Set 7:
(6 comments)
https://review.coreboot.org/c/coreboot/+/38601/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38601/2//COMMIT_MSG@10 PS2, Line 10: Linux
What version? Please paste the error message.
Done
https://review.coreboot.org/c/coreboot/+/38601/2//COMMIT_MSG@11 PS2, Line 11: because it was not declared in the DSDT.
Reflow for 75 characters text width?
Done
https://review.coreboot.org/c/coreboot/+/38601/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38601/3//COMMIT_MSG@7 PS3, Line 7: asus/p2b,asus/p2b-ls
mb/asus/{p2b,p2b-ls}/dsdt. […]
Done
https://review.coreboot.org/c/coreboot/+/38601/3//COMMIT_MSG@9 PS3, Line 9: sb/intel/i82371eb/isa.c has code that fills this path : with CPU info, which was triggering errors in Linux 4.4.18 : because it was not declared in the DSDT.
I would rewrite this part a bit: […]
Done
https://review.coreboot.org/c/coreboot/+/38601/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38601/5//COMMIT_MSG@12 PS5, Line 12:
I’d add for people grep’ing the git history for such an error. […]
Ack
https://review.coreboot.org/c/coreboot/+/38601/2/src/mainboard/asus/p2b-ls/d... File src/mainboard/asus/p2b-ls/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/38601/2/src/mainboard/asus/p2b-ls/d... PS2, Line 197: Name (_UID, 0x02)
This is just to prevent any PNP0C02 ambiguity. The declaration in isabridge.asl has a UID of 1.
File is gone