Keith Hui has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38601 )
Change subject: asus/p2b,asus/p2b-ls: Declare _SB.PCI0.MBRS in DSDT ......................................................................
asus/p2b,asus/p2b-ls: Declare _SB.PCI0.MBRS in DSDT
sb/intel/i82371eb/isa.c has code that fills this path with CPU info, which was triggering errors in Linux because it was not declared in the DSDT.
Change-Id: Ib85dd02504b068bb7ea71be2f22e425f3831595a Signed-off-by: Keith Hui buurin@gmail.com --- M src/mainboard/asus/p2b-ls/dsdt.asl M src/mainboard/asus/p2b/dsdt.asl 2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/38601/1
diff --git a/src/mainboard/asus/p2b-ls/dsdt.asl b/src/mainboard/asus/p2b-ls/dsdt.asl index 83e1df6..b350bc9 100644 --- a/src/mainboard/asus/p2b-ls/dsdt.asl +++ b/src/mainboard/asus/p2b-ls/dsdt.asl @@ -175,6 +175,7 @@
}) #include <northbridge/intel/i440bx/acpi/sb_pci0_crs.asl> + #include <southbridge/intel/i82371eb/acpi/isabridge.asl>
/* Begin southbridge block */ Device (PX40) @@ -193,6 +194,7 @@ Device (SYSR) { Name (_HID, EisaId ("PNP0C02")) + Name (_UID, 0x02) Method (_CRS, 0, NotSerialized) { Name (BUF1, ResourceTemplate () diff --git a/src/mainboard/asus/p2b/dsdt.asl b/src/mainboard/asus/p2b/dsdt.asl index 279f772..3fc531a 100644 --- a/src/mainboard/asus/p2b/dsdt.asl +++ b/src/mainboard/asus/p2b/dsdt.asl @@ -161,6 +161,7 @@
}) #include <northbridge/intel/i440bx/acpi/sb_pci0_crs.asl> + #include <southbridge/intel/i82371eb/acpi/isabridge.asl>
/* Begin southbridge block */ Device (PX40) @@ -179,6 +180,7 @@ Device (SYSR) { Name (_HID, EisaId ("PNP0C02")) + Name (_UID, 0x02) Method (_CRS, 0, NotSerialized) { Name (BUF1, ResourceTemplate ()
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38601 )
Change subject: asus/p2b,asus/p2b-ls: Declare _SB.PCI0.MBRS in DSDT ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38601/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38601/2//COMMIT_MSG@10 PS2, Line 10: Linux What version? Please paste the error message.
https://review.coreboot.org/c/coreboot/+/38601/2//COMMIT_MSG@11 PS2, Line 11: because it was not declared in the DSDT. Reflow for 75 characters text width?
https://review.coreboot.org/c/coreboot/+/38601/2/src/mainboard/asus/p2b-ls/d... File src/mainboard/asus/p2b-ls/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/38601/2/src/mainboard/asus/p2b-ls/d... PS2, Line 197: Name (_UID, 0x02) What error does this fix?
Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38601 )
Change subject: asus/p2b,asus/p2b-ls: Declare _SB.PCI0.MBRS in DSDT ......................................................................
Patch Set 2:
(1 comment)
The kernel is 4.4.18 with SMP support, the stock kernel of slackware 14.2 actually.
You can see the error in this kernel log, around line 130.
https://review.coreboot.org/cgit/board-status.git/tree/asus/p2b-ls/4.11-839-...
https://review.coreboot.org/c/coreboot/+/38601/2/src/mainboard/asus/p2b-ls/d... File src/mainboard/asus/p2b-ls/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/38601/2/src/mainboard/asus/p2b-ls/d... PS2, Line 197: Name (_UID, 0x02)
What error does this fix?
This is just to prevent any PNP0C02 ambiguity. The declaration in isabridge.asl has a UID of 1.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38601
to look at the new patch set (#3).
Change subject: asus/p2b,asus/p2b-ls: Declare _SB.PCI0.MBRS in DSDT ......................................................................
asus/p2b,asus/p2b-ls: Declare _SB.PCI0.MBRS in DSDT
sb/intel/i82371eb/isa.c has code that fills this path with CPU info, which was triggering errors in Linux 4.4.18 because it was not declared in the DSDT.
Change-Id: Ib85dd02504b068bb7ea71be2f22e425f3831595a Signed-off-by: Keith Hui buurin@gmail.com --- M src/mainboard/asus/p2b-ls/dsdt.asl M src/mainboard/asus/p2b/dsdt.asl 2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/38601/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38601 )
Change subject: asus/p2b,asus/p2b-ls: Declare _SB.PCI0.MBRS in DSDT ......................................................................
Patch Set 3: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/38601/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38601/3//COMMIT_MSG@7 PS3, Line 7: asus/p2b,asus/p2b-ls mb/asus/{p2b,p2b-ls}/dsdt.asl
https://review.coreboot.org/c/coreboot/+/38601/3//COMMIT_MSG@9 PS3, Line 9: sb/intel/i82371eb/isa.c has code that fills this path : with CPU info, which was triggering errors in Linux 4.4.18 : because it was not declared in the DSDT. I would rewrite this part a bit:
The code in sb/intel/i82371eb/isa.c fills _SB.PCI0.MBRS with CPU info. However, as this path was not declared in the DSDT, Linux 4.4.18 complained about it.
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38601
to look at the new patch set (#4).
Change subject: asus/p2b*: Declare _SB.PCI0.MBRS in DSDT ......................................................................
asus/p2b*: Declare _SB.PCI0.MBRS in DSDT
sb/intel/i82371eb/isa.c has code that fills this path with CPU info. Because it was not declared in the DSDT, Linux kernel 4.4.18 as used in Slackware 14.2 complains.
Change-Id: Ib85dd02504b068bb7ea71be2f22e425f3831595a Signed-off-by: Keith Hui buurin@gmail.com --- M src/mainboard/asus/p2b/dsdt.asl 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/38601/4
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38601
to look at the new patch set (#5).
Change subject: asus/p2b*: Declare _SB.PCI0.MBRS in DSDT ......................................................................
asus/p2b*: Declare _SB.PCI0.MBRS in DSDT
sb/intel/i82371eb/isa.c has code that fills this path with CPU info. Because it was not declared in the DSDT, Linux kernel 4.4.18 as used in Slackware 14.2 complains.
Change-Id: Ib85dd02504b068bb7ea71be2f22e425f3831595a Signed-off-by: Keith Hui buurin@gmail.com --- M src/mainboard/asus/p2b/dsdt.asl 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/38601/5
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38601 )
Change subject: asus/p2b*: Declare _SB.PCI0.MBRS in DSDT ......................................................................
Patch Set 5: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38601 )
Change subject: asus/p2b*: Declare _SB.PCI0.MBRS in DSDT ......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/38601/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38601/5//COMMIT_MSG@12 PS5, Line 12: I’d add for people grep’ing the git history for such an error.
``` [ 0.006014] ACPI Error: [_SB_.PCI0.MBRS] Namespace lookup failure, AE_NOT_FOUND (20150930/dswload-210) [ 0.006337] ACPI Exception: AE_NOT_FOUND, During name lookup/catalog (20150930/psobject-227) [ 0.006622] ACPI Exception: AE_NOT_FOUND, (SSDT:COREBOOT) while loading table (20150930/tbxfload-193) [ 0.006896] ACPI Error: 1 table load failures, 1 successful (20150930/tbxfload-214) ```
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38601 )
Change subject: asus/p2b*: Declare _SB.PCI0.MBRS in DSDT ......................................................................
Patch Set 7:
(6 comments)
https://review.coreboot.org/c/coreboot/+/38601/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38601/2//COMMIT_MSG@10 PS2, Line 10: Linux
What version? Please paste the error message.
Done
https://review.coreboot.org/c/coreboot/+/38601/2//COMMIT_MSG@11 PS2, Line 11: because it was not declared in the DSDT.
Reflow for 75 characters text width?
Done
https://review.coreboot.org/c/coreboot/+/38601/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38601/3//COMMIT_MSG@7 PS3, Line 7: asus/p2b,asus/p2b-ls
mb/asus/{p2b,p2b-ls}/dsdt. […]
Done
https://review.coreboot.org/c/coreboot/+/38601/3//COMMIT_MSG@9 PS3, Line 9: sb/intel/i82371eb/isa.c has code that fills this path : with CPU info, which was triggering errors in Linux 4.4.18 : because it was not declared in the DSDT.
I would rewrite this part a bit: […]
Done
https://review.coreboot.org/c/coreboot/+/38601/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38601/5//COMMIT_MSG@12 PS5, Line 12:
I’d add for people grep’ing the git history for such an error. […]
Ack
https://review.coreboot.org/c/coreboot/+/38601/2/src/mainboard/asus/p2b-ls/d... File src/mainboard/asus/p2b-ls/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/38601/2/src/mainboard/asus/p2b-ls/d... PS2, Line 197: Name (_UID, 0x02)
This is just to prevent any PNP0C02 ambiguity. The declaration in isabridge.asl has a UID of 1.
File is gone
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38601 )
Change subject: asus/p2b*: Declare _SB.PCI0.MBRS in DSDT ......................................................................
asus/p2b*: Declare _SB.PCI0.MBRS in DSDT
sb/intel/i82371eb/isa.c has code that fills this path with CPU info. Because it was not declared in the DSDT, Linux kernel 4.4.18 as used in Slackware 14.2 complains.
Change-Id: Ib85dd02504b068bb7ea71be2f22e425f3831595a Signed-off-by: Keith Hui buurin@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38601 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/asus/p2b/dsdt.asl 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/asus/p2b/dsdt.asl b/src/mainboard/asus/p2b/dsdt.asl index 05af720..5bc5d72 100644 --- a/src/mainboard/asus/p2b/dsdt.asl +++ b/src/mainboard/asus/p2b/dsdt.asl @@ -166,6 +166,7 @@
}) #include <northbridge/intel/i440bx/acpi/sb_pci0_crs.asl> + #include <southbridge/intel/i82371eb/acpi/isabridge.asl>
/* Begin southbridge block */ Device (PX40) @@ -184,6 +185,7 @@ Device (SYSR) { Name (_HID, EisaId ("PNP0C02")) + Name (_UID, 0x02) Method (_CRS, 0, NotSerialized) { Name (BUF1, ResourceTemplate ()
-
Angel Pons (Code Review) -
Keith Hui (Code Review)
-
Paul Menzel (Code Review)