Attention is currently required from: char, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72827 )
Change subject: Adding new ITE IT8987e ......................................................................
Patch Set 2: Verified-1
(32 comments)
File src/superio/ite/it8987e/superio.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/69097fd5_f9e41c33 PS2, Line 18: if (!dev->enabled) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/64ebe412_51aad5bf PS2, Line 18: if (!dev->enabled) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/d36f66b2_ce02a520 PS2, Line 19: return; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/19c48683_cc26a509 PS2, Line 19: return; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/1e9c6237_2f7ff17c PS2, Line 21: switch (dev->path.pnp.device) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/5d6678f0_b71c095e PS2, Line 21: switch (dev->path.pnp.device) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/b3dc3231_f3c02de1 PS2, Line 22: case IT8987E_KBCK: code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/46206cdb_ebc19e5c PS2, Line 22: case IT8987E_KBCK: please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/42267015_593907f0 PS2, Line 23: pc_keyboard_init(NO_AUX_DEVICE); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/3981ae89_751cd255 PS2, Line 23: pc_keyboard_init(NO_AUX_DEVICE); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/3b6e3ca7_3e344b78 PS2, Line 24: break; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/90e2ce86_f2d886da PS2, Line 24: break; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/e684a61d_16a6999d PS2, Line 25: default: code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/77b4acad_4d536d5f PS2, Line 27: break; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/17eaf571_f2982883 PS2, Line 27: break; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/b33ae4b4_4671021c PS2, Line 28: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/4a39f319_6d63c46e PS2, Line 28: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/18dab40f_32e34f3c PS2, Line 41: { NULL, IT8987E_SP1, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/43a931b2_db255dce PS2, Line 41: { NULL, IT8987E_SP1, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/84ada449_46cbbae9 PS2, Line 42: { NULL, IT8987E_SP2, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/4833d30e_8f459145 PS2, Line 42: { NULL, IT8987E_SP2, PNP_IO0 | PNP_IRQ0, 0x0ff8, }, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/6998c502_b3cd0a51 PS2, Line 65: const struct superio_ite_it8987e_config *conf; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/399b493c_573a1190 PS2, Line 65: const struct superio_ite_it8987e_config *conf; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/da0db5bf_5ae43c16 PS2, Line 69: conf = dev->chip_info; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/64ba510f_2a3354c2 PS2, Line 69: conf = dev->chip_info; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/9fe94037_12b7afda PS2, Line 70: if (!conf) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/79b3253a_dbb41ef3 PS2, Line 70: if (!conf) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/89f74648_bf37d440 PS2, Line 70: if (!conf) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/8ad5c21b_c76c4583 PS2, Line 74: printk(BIOS_INFO, "IT8987E: init ITE EC\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/1b11ef1f_c21cdddc PS2, Line 75: ite_ec_init(0x25e, &conf->ec); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/d6691f56_dd7826b6 PS2, Line 75: ite_ec_init(0x25e, &conf->ec); please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-169933): https://review.coreboot.org/c/coreboot/+/72827/comment/2e2d4ca2_eee65a16 PS2, Line 75: ite_ec_init(0x25e, &conf->ec); please, no spaces at the start of a line