Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40306 )
Change subject: drivers/ipmi: Add IPMI read FRU chassis info area
......................................................................
Patch Set 13:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40306/8/src/drivers/ipmi/ipmi_fru.c
File src/drivers/ipmi/ipmi_fru.c:
https://review.coreboot.org/c/coreboot/+/40306/8/src/drivers/ipmi/ipmi_fru.c...
PS8, Line 123: void
I uploaded a patchset for this function, after it's reviewed ok I will modify similar changes to […]
Done
https://review.coreboot.org/c/coreboot/+/40306/12/src/drivers/ipmi/ipmi_fru....
File src/drivers/ipmi/ipmi_fru.c:
https://review.coreboot.org/c/coreboot/+/40306/12/src/drivers/ipmi/ipmi_fru....
PS12, Line 251: read_data_string
Split to CB:40621.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40306
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb53c20f8eb4b7720bf1fe349e6aaebaa4c37247
Gerrit-Change-Number: 40306
Gerrit-PatchSet: 13
Gerrit-Owner: Johnny Lin
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 23 Apr 2020 03:08:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Johnny Lin
Comment-In-Reply-To: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-MessageType: comment