Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33433 )
Change subject: mainboard/facebook/fbg1701: Configure TC358860 eDP to MIPI controller ......................................................................
Patch Set 15: Code-Review+2
(2 comments)
Looks good. I added two comments. They are just "for the record", additional info I found. There's no need to update the patch.
https://review.coreboot.org/#/c/33433/15/src/mainboard/facebook/fbg1701/rams... File src/mainboard/facebook/fbg1701/ramstage.c:
https://review.coreboot.org/#/c/33433/15/src/mainboard/facebook/fbg1701/rams... PS15, Line 335: if (cpld_version < 7) : edptable = tc348860_table; : else : edptable = b101uan08_table; Looks like the TC348860 is a discrete eDP to MIPI DSI converter. The B101UAN08 looks like an eDP LCD panel, or am I wrong? I would comment on that.
https://review.coreboot.org/#/c/33433/15/src/mainboard/facebook/fbg1701/rams... PS15, Line 363: 1920 Looks like this board is part of an integrated device. I would guess that '1920' refers to the resolution of the integrated panel? I would use '1920x1200' instead.
(the '1200' should be correct, but please double check)