Hello Patrick Rudolph, build bot (Jenkins), Damien Zammit,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32054
to look at the new patch set (#2).
Change subject: nb/intel/pineview: Correct unsigned integer check in msbpos ......................................................................
nb/intel/pineview: Correct unsigned integer check in msbpos
The check i >= 0 is always true for an unsigned integer, causing msbpos(0) to hang. We correct it to i != 0.
Note this has no material change since the code guards against finding the msb of 0 anyway, but it fixes CID 1347356, 1347386.
Also fix checkpatch trailing statement lints.
Signed-off-by: Jacob Garber jgarber1@ualberta.ca Change-Id: Ic5be50846cc545dcd48593e5ed3fd6068a6104cb --- M src/northbridge/intel/pineview/raminit.c 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/32054/2