Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46669 )
Change subject: soc/amd/common/acpi: Create platform.asl to define acpi transitions ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/46669/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46669/2//COMMIT_MSG@16 PS2, Line 16: Signed-Off-By Jenkins is complaining: "No Signed-off-by line in commit message"
O and B need to be lowercase. "Signed-off-by"
https://review.coreboot.org/c/coreboot/+/46669/2/src/soc/amd/common/acpi/pla... File src/soc/amd/common/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/46669/2/src/soc/amd/common/acpi/pla... PS2, Line 8: { nit: space before {