Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32460 )
Change subject: mediatek/mt8183: Add SPI GPIO driving setting
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32460/2/src/soc/mediatek/mt8183/gpio.c
File src/soc/mediatek/mt8183/gpio.c:
https://review.coreboot.org/#/c/32460/2/src/soc/mediatek/mt8183/gpio.c@140
PS2, Line 140: 0x4
Where does this 0x4 come from? Is this a drive strength? Or a bit field? A comment about what exactl […]
Also, does this affects all SPI controllers or only one?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32460
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95002ec71abd751c33c089185db04ed4a8686699
Gerrit-Change-Number: 32460
Gerrit-PatchSet: 2
Gerrit-Owner: Mengqi Zhang
Mengqi.Zhang@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Mengqi Zhang
Mengqi.Zhang@mediatek.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 26 Apr 2019 22:51:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment