[coreboot-gerrit] Change in coreboot[master]: soc/intel/tgl: Disable hybrid storage mode in recovery mode

[Rizwan Qureshi (Code Review)]

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42282 )

Change subject: soc/intel/tgl: Disable hybrid storage mode in recovery mode
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42282/2/src/soc/intel/tigerlake/fsp... 
File src/soc/intel/tigerlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/42282/2/src/soc/intel/tigerlake/fsp... 
PS2, Line 255: vboot_recovery_mode_enabled()
The dynamic hybrid storage configuration involves updating straps. Since the "CSE" RO code does not support updating the straps, the check should be to see if CSE has booted from RO partition instead of checking Chrome/VBOOT recovery mode.

if (CONFIG(SOC_INTEL_CSE_LITE_SKU) && cse_is_rw())

cse_is_rw() could be implemented in src/soc/intel/common/block/cse/cse_lite.c