HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/50535 )
Change subject: src: Remove unused <string.h> ......................................................................
src: Remove unused <string.h>
Found using: diff <(git grep -l '#include <string.h>' -- src/) <(git grep -l 'STRINGIFY|memcpy|memmove|memset|memcmp|memchr|strdup|strconcat|strnlen|strlen|strchr|strncpy|strcpy|strcmp|strncmp|strspn|strcspn|strstr|strtok_r|strtok|atol|strrchr|skip_atoi' -- src/)|grep '<'
Change-Id: I4cdf64119e9bfa377520d7e343434f5a6ddab3a8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/x86/smbios_defaults.c M src/console/vsprintf.c M src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c M src/drivers/generic/gpio_keys/gpio_keys.c M src/drivers/i2c/generic/generic.c M src/drivers/i2c/gpiomux/bus/bus.c M src/drivers/i2c/gpiomux/mux/mux.c M src/drivers/i2c/hid/hid.c M src/drivers/i2c/sx9310/sx9310.c M src/drivers/i2c/sx9324/sx9324.c M src/drivers/intel/gma/acpi.c M src/drivers/intel/usb4/retimer/retimer.c M src/drivers/spi/acpi/acpi.c M src/drivers/uart/acpi/acpi.c M src/ec/google/chromeec/ec_skuid.c M src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c M src/mainboard/google/dedede/romstage.c M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/gru/sdram_configs.c M src/mainboard/google/hatch/romstage_spd_cbfs.c M src/mainboard/google/kahlee/mainboard.c M src/mainboard/google/kukui/boardid.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/poppy/variants/nami/mainboard.c M src/mainboard/google/poppy/variants/nautilus/mainboard.c M src/mainboard/google/poppy/variants/rammus/mainboard.c M src/mainboard/google/reef/mainboard.c M src/mainboard/google/zork/variants/dirinboz/variant.c M src/mainboard/google/zork/variants/gumboz/variant.c M src/mainboard/intel/adlrvp/mainboard.c M src/mainboard/intel/adlrvp/romstage_fsp_params.c M src/mainboard/intel/tglrvp/mainboard.c M src/mainboard/kontron/986lcd-m/mainboard.c M src/mainboard/ocp/deltalake/ipmi.c M src/mainboard/ocp/deltalake/loglevel_vpd.c M src/mainboard/ocp/deltalake/romstage.c M src/mainboard/prodrive/hermes/mainboard.c M src/mainboard/protectli/vault_bsw/acpi_tables.c M src/northbridge/intel/haswell/gma.c M src/northbridge/intel/sandybridge/raminit_common.c M src/security/intel/txt/logging.c M src/soc/amd/picasso/acpi.c M src/soc/amd/stoneyridge/acpi.c M src/soc/intel/alderlake/bootblock/report_platform.c M src/soc/intel/apollolake/acpi.c M src/soc/intel/baytrail/ramstage.c M src/soc/intel/baytrail/southcluster.c M src/soc/intel/braswell/ramstage.c M src/soc/intel/broadwell/acpi.c M src/soc/intel/broadwell/pch/lpc.c M src/soc/intel/broadwell/pch/ramstage.c M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/elkhartlake/bootblock/report_platform.c M src/soc/intel/elkhartlake/fsp_params.c M src/soc/intel/elkhartlake/romstage/fsp_params.c M src/soc/intel/jasperlake/bootblock/report_platform.c M src/soc/intel/xeon_sp/acpi.c M src/soc/intel/xeon_sp/cpx/soc_util.c M src/soc/mediatek/mt8192/dramc_pi_basic_api.c M src/soc/mediatek/mt8192/dramc_pi_calibration_api.c M src/soc/mediatek/mt8192/pmif.c M src/soc/mediatek/mt8192/pmif_spmi.c M src/soc/qualcomm/sc7180/carve_out.c M src/soc/qualcomm/sc7180/display/dsi_phy_pll.c M src/southbridge/intel/i82801gx/lpc.c M src/southbridge/intel/i82801ix/lpc.c M src/southbridge/intel/i82801jx/lpc.c M src/southbridge/intel/ibexpeak/lpc.c M src/southbridge/intel/lynxpoint/lpc.c 69 files changed, 10 insertions(+), 69 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/50535/1
diff --git a/src/arch/x86/smbios_defaults.c b/src/arch/x86/smbios_defaults.c index 3d26bbb..cef9b14 100644 --- a/src/arch/x86/smbios_defaults.c +++ b/src/arch/x86/smbios_defaults.c @@ -3,7 +3,6 @@ #include <memory_info.h> #include <smbios.h> #include <stdint.h> -#include <string.h>
/* this function will fill the corresponding locator */ __weak void smbios_fill_dimm_locator(const struct dimm_info *dimm, struct smbios_type17 *t) diff --git a/src/console/vsprintf.c b/src/console/vsprintf.c index 06b9e49..093b2d3 100644 --- a/src/console/vsprintf.c +++ b/src/console/vsprintf.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <console/vtxprintf.h> -#include <string.h>
struct vsnprintf_context { char *str_buf; diff --git a/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c b/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c index b5be31d..6ab7d6b 100644 --- a/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c +++ b/src/drivers/amd/i2s_machine_dev/i2s_machine_dev.c @@ -3,7 +3,6 @@ #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <device/device.h> -#include <string.h> #include "chip.h" #include <console/console.h>
diff --git a/src/drivers/generic/gpio_keys/gpio_keys.c b/src/drivers/generic/gpio_keys/gpio_keys.c index 3d273a0..0a44243 100644 --- a/src/drivers/generic/gpio_keys/gpio_keys.c +++ b/src/drivers/generic/gpio_keys/gpio_keys.c @@ -4,7 +4,6 @@ #include <acpi/acpigen.h> #include <device/device.h> #include <device/path.h> -#include <string.h>
#include "chip.h"
diff --git a/src/drivers/i2c/generic/generic.c b/src/drivers/i2c/generic/generic.c index 1c7267e..827da42 100644 --- a/src/drivers/i2c/generic/generic.c +++ b/src/drivers/i2c/generic/generic.c @@ -7,7 +7,7 @@ #include <device/device.h> #include <device/path.h> #include <gpio.h> -#include <string.h> + #include "chip.h"
#if CONFIG(HAVE_ACPI_TABLES) diff --git a/src/drivers/i2c/gpiomux/bus/bus.c b/src/drivers/i2c/gpiomux/bus/bus.c index 0bcf36a..7530e54 100644 --- a/src/drivers/i2c/gpiomux/bus/bus.c +++ b/src/drivers/i2c/gpiomux/bus/bus.c @@ -6,7 +6,7 @@ #include <device/device.h> #include <device/path.h> #include <stdlib.h> -#include <string.h> + #include "chip.h"
static const char *i2c_gpiomux_bus_acpi_name(const struct device *dev) diff --git a/src/drivers/i2c/gpiomux/mux/mux.c b/src/drivers/i2c/gpiomux/mux/mux.c index c1ae758..0730536 100644 --- a/src/drivers/i2c/gpiomux/mux/mux.c +++ b/src/drivers/i2c/gpiomux/mux/mux.c @@ -6,7 +6,7 @@ #include <device/device.h> #include <device/path.h> #include <stdlib.h> -#include <string.h> + #include "chip.h"
static const char *i2c_gpiomux_mux_acpi_name(const struct device *dev) diff --git a/src/drivers/i2c/hid/hid.c b/src/drivers/i2c/hid/hid.c index 2d213eb..0f9f814 100644 --- a/src/drivers/i2c/hid/hid.c +++ b/src/drivers/i2c/hid/hid.c @@ -2,7 +2,6 @@
#include <acpi/acpigen_dsm.h> #include <device/device.h> -#include <string.h> #include "chip.h" #include <gpio.h> #include <console/console.h> diff --git a/src/drivers/i2c/sx9310/sx9310.c b/src/drivers/i2c/sx9310/sx9310.c index 8dc57a2..86779f9 100644 --- a/src/drivers/i2c/sx9310/sx9310.c +++ b/src/drivers/i2c/sx9310/sx9310.c @@ -6,7 +6,7 @@ #include <device/i2c_simple.h> #include <device/device.h> #include <device/path.h> -#include <string.h> + #include "chip.h"
#define I2C_SX9310_ACPI_ID "STH9310" diff --git a/src/drivers/i2c/sx9324/sx9324.c b/src/drivers/i2c/sx9324/sx9324.c index 2ca9f36..77d4b9f 100644 --- a/src/drivers/i2c/sx9324/sx9324.c +++ b/src/drivers/i2c/sx9324/sx9324.c @@ -6,7 +6,7 @@ #include <device/i2c_simple.h> #include <device/device.h> #include <device/path.h> -#include <string.h> + #include "chip.h"
#define I2C_SX9324_ACPI_ID "STH9324" diff --git a/src/drivers/intel/gma/acpi.c b/src/drivers/intel/gma/acpi.c index 4a89bb9..66209b1 100644 --- a/src/drivers/intel/gma/acpi.c +++ b/src/drivers/intel/gma/acpi.c @@ -2,7 +2,7 @@
#include <acpi/acpi.h> #include <acpi/acpigen.h> -#include <string.h> + #include "i915.h"
void diff --git a/src/drivers/intel/usb4/retimer/retimer.c b/src/drivers/intel/usb4/retimer/retimer.c index f884ac60..4e56d64 100644 --- a/src/drivers/intel/usb4/retimer/retimer.c +++ b/src/drivers/intel/usb4/retimer/retimer.c @@ -6,7 +6,7 @@ #include <device/device.h> #include <device/path.h> #include <gpio.h> -#include <string.h> + #include "chip.h" #include "retimer.h"
diff --git a/src/drivers/spi/acpi/acpi.c b/src/drivers/spi/acpi/acpi.c index b23bc9d..b246d17 100644 --- a/src/drivers/spi/acpi/acpi.c +++ b/src/drivers/spi/acpi/acpi.c @@ -7,7 +7,7 @@ #include <device/path.h> #include <device/spi.h> #include <spi-generic.h> -#include <string.h> + #include "chip.h"
static int spi_acpi_get_bus(const struct device *dev) diff --git a/src/drivers/uart/acpi/acpi.c b/src/drivers/uart/acpi/acpi.c index d4b14aa..855d0f9 100644 --- a/src/drivers/uart/acpi/acpi.c +++ b/src/drivers/uart/acpi/acpi.c @@ -4,7 +4,7 @@ #include <acpi/acpigen.h> #include <console/console.h> #include <device/path.h> -#include <string.h> + #include "chip.h"
static bool uart_acpi_add_gpios_to_crs(struct drivers_uart_acpi_config *config) diff --git a/src/ec/google/chromeec/ec_skuid.c b/src/ec/google/chromeec/ec_skuid.c index 39a1c0b..5bfa238 100644 --- a/src/ec/google/chromeec/ec_skuid.c +++ b/src/ec/google/chromeec/ec_skuid.c @@ -4,7 +4,6 @@ #include <boardid.h> #include <ec/google/chromeec/ec.h> #include <console/console.h> -#include <string.h> #include <smbios.h>
uint32_t google_chromeec_get_board_sku(void) diff --git a/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c b/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c index e61ecfd..d6bca74 100644 --- a/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c +++ b/src/ec/google/chromeec/i2c_tunnel/i2c_tunnel.c @@ -5,7 +5,7 @@ #include <console/console.h> #include <device/device.h> #include <device/path.h> -#include <string.h> + #include "chip.h"
#define CROS_EC_I2C_TUNNEL_HID "GOOG0012" diff --git a/src/mainboard/google/dedede/romstage.c b/src/mainboard/google/dedede/romstage.c index f6a94ec..34810b4 100644 --- a/src/mainboard/google/dedede/romstage.c +++ b/src/mainboard/google/dedede/romstage.c @@ -6,7 +6,6 @@ #include <memory_info.h> #include <soc/meminit.h> #include <soc/romstage.h> -#include <string.h> #include <variant/gpio.h>
void mainboard_memory_init_params(FSPM_UPD *memupd) diff --git a/src/mainboard/google/fizz/mainboard.c b/src/mainboard/google/fizz/mainboard.c index 0945b9c..2fa0ce6 100644 --- a/src/mainboard/google/fizz/mainboard.c +++ b/src/mainboard/google/fizz/mainboard.c @@ -14,7 +14,6 @@ #include <soc/gpio.h> #include <soc/pci_devs.h> #include <soc/nhlt.h> -#include <string.h> #include <timer.h> #include <vendorcode/google/chromeos/chromeos.h>
diff --git a/src/mainboard/google/gru/sdram_configs.c b/src/mainboard/google/gru/sdram_configs.c index 2aceb9f..1683f45 100644 --- a/src/mainboard/google/gru/sdram_configs.c +++ b/src/mainboard/google/gru/sdram_configs.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <gpio.h> #include <soc/sdram.h> -#include <string.h> #include <types.h>
static const char *sdram_configs[] = { diff --git a/src/mainboard/google/hatch/romstage_spd_cbfs.c b/src/mainboard/google/hatch/romstage_spd_cbfs.c index 8a12d70..eb5153c 100644 --- a/src/mainboard/google/hatch/romstage_spd_cbfs.c +++ b/src/mainboard/google/hatch/romstage_spd_cbfs.c @@ -6,7 +6,6 @@ #include <memory_info.h> #include <soc/cnl_memcfg_init.h> #include <soc/romstage.h> -#include <string.h> #include <variant/gpio.h>
/* diff --git a/src/mainboard/google/kahlee/mainboard.c b/src/mainboard/google/kahlee/mainboard.c index 570f20c..5705093 100644 --- a/src/mainboard/google/kahlee/mainboard.c +++ b/src/mainboard/google/kahlee/mainboard.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <string.h> #include <console/console.h> #include <device/device.h> #include <device/mmio.h> diff --git a/src/mainboard/google/kukui/boardid.c b/src/mainboard/google/kukui/boardid.c index 04ae7db..1174756 100644 --- a/src/mainboard/google/kukui/boardid.c +++ b/src/mainboard/google/kukui/boardid.c @@ -16,7 +16,6 @@ #include <soc/auxadc_common.h> #include <soc/i2c.h> #include <soc/pmic_wrap_common.h> -#include <string.h>
/* For CBI un-provisioned/corrupted Flapjack board. */ #define FLAPJACK_UNDEF_SKU_ID 0 diff --git a/src/mainboard/google/kukui/mainboard.c b/src/mainboard/google/kukui/mainboard.c index 7efa01b..51779f5 100644 --- a/src/mainboard/google/kukui/mainboard.c +++ b/src/mainboard/google/kukui/mainboard.c @@ -19,7 +19,6 @@ #include <soc/mtcmos.h> #include <soc/spm.h> #include <soc/usb.h> -#include <string.h>
#include "gpio.h" #include "panel.h" diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c index 1387716..d888342 100644 --- a/src/mainboard/google/poppy/variants/nami/mainboard.c +++ b/src/mainboard/google/poppy/variants/nami/mainboard.c @@ -13,7 +13,6 @@ #include <intelblocks/power_limit.h> #include <smbios.h> #include <soc/ramstage.h> -#include <string.h> #include <variant/sku.h>
#define PL2_I7_SKU 44 diff --git a/src/mainboard/google/poppy/variants/nautilus/mainboard.c b/src/mainboard/google/poppy/variants/nautilus/mainboard.c index 7350fb0..b09a708 100644 --- a/src/mainboard/google/poppy/variants/nautilus/mainboard.c +++ b/src/mainboard/google/poppy/variants/nautilus/mainboard.c @@ -6,7 +6,6 @@ #include <device/device.h> #include <device/pci_ops.h> #include <smbios.h> -#include <string.h> #include <variant/sku.h>
#define R_PCH_OC_WDT_CTL 0x54 diff --git a/src/mainboard/google/poppy/variants/rammus/mainboard.c b/src/mainboard/google/poppy/variants/rammus/mainboard.c index 66e2527..6fa93dd 100644 --- a/src/mainboard/google/poppy/variants/rammus/mainboard.c +++ b/src/mainboard/google/poppy/variants/rammus/mainboard.c @@ -3,7 +3,6 @@ #include <baseboard/variants.h> #include <ec/google/chromeec/ec.h> #include <smbios.h> -#include <string.h>
#define SKU_UNKNOWN 0xFFFFFFFF
diff --git a/src/mainboard/google/reef/mainboard.c b/src/mainboard/google/reef/mainboard.c index e007880..fa8096b 100644 --- a/src/mainboard/google/reef/mainboard.c +++ b/src/mainboard/google/reef/mainboard.c @@ -11,7 +11,6 @@ #include <smbios.h> #include <soc/gpio.h> #include <soc/nhlt.h> -#include <string.h> #include <vendorcode/google/chromeos/chromeos.h> #include <variant/ec.h> #include <variant/gpio.h> diff --git a/src/mainboard/google/zork/variants/dirinboz/variant.c b/src/mainboard/google/zork/variants/dirinboz/variant.c index 4dd371a..ebe2292 100644 --- a/src/mainboard/google/zork/variants/dirinboz/variant.c +++ b/src/mainboard/google/zork/variants/dirinboz/variant.c @@ -6,7 +6,6 @@ #include <soc/pci_devs.h> #include <ec/google/chromeec/ec.h> #include <ec/google/chromeec/i2c_tunnel/chip.h> -#include <string.h>
/* FIXME: Comments seem to suggest these are not entirely correct. */ static const fsp_ddi_descriptor non_hdmi_ddi_descriptors[] = { diff --git a/src/mainboard/google/zork/variants/gumboz/variant.c b/src/mainboard/google/zork/variants/gumboz/variant.c index 4dd371a..ebe2292 100644 --- a/src/mainboard/google/zork/variants/gumboz/variant.c +++ b/src/mainboard/google/zork/variants/gumboz/variant.c @@ -6,7 +6,6 @@ #include <soc/pci_devs.h> #include <ec/google/chromeec/ec.h> #include <ec/google/chromeec/i2c_tunnel/chip.h> -#include <string.h>
/* FIXME: Comments seem to suggest these are not entirely correct. */ static const fsp_ddi_descriptor non_hdmi_ddi_descriptors[] = { diff --git a/src/mainboard/intel/adlrvp/mainboard.c b/src/mainboard/intel/adlrvp/mainboard.c index fb25578..26004ca 100644 --- a/src/mainboard/intel/adlrvp/mainboard.c +++ b/src/mainboard/intel/adlrvp/mainboard.c @@ -8,7 +8,6 @@ #include <vendorcode/google/chromeos/chromeos.h> #include <smbios.h> #include <stdint.h> -#include <string.h>
#include "board_id.h"
diff --git a/src/mainboard/intel/adlrvp/romstage_fsp_params.c b/src/mainboard/intel/adlrvp/romstage_fsp_params.c index 5b02e78..8a179d6 100644 --- a/src/mainboard/intel/adlrvp/romstage_fsp_params.c +++ b/src/mainboard/intel/adlrvp/romstage_fsp_params.c @@ -5,7 +5,6 @@ #include <fsp/api.h> #include <soc/romstage.h> #include <spd_bin.h> -#include <string.h> #include <soc/meminit.h> #include <baseboard/variants.h> #include "board_id.h" diff --git a/src/mainboard/intel/tglrvp/mainboard.c b/src/mainboard/intel/tglrvp/mainboard.c index 82877ed..c590eed 100644 --- a/src/mainboard/intel/tglrvp/mainboard.c +++ b/src/mainboard/intel/tglrvp/mainboard.c @@ -7,7 +7,6 @@ #include <soc/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> #include <smbios.h> -#include <string.h>
const char *smbios_system_sku(void) { diff --git a/src/mainboard/kontron/986lcd-m/mainboard.c b/src/mainboard/kontron/986lcd-m/mainboard.c index 26a800a..729ca6d 100644 --- a/src/mainboard/kontron/986lcd-m/mainboard.c +++ b/src/mainboard/kontron/986lcd-m/mainboard.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <string.h> #include <types.h> #include <device/device.h> #include <console/console.h> diff --git a/src/mainboard/ocp/deltalake/ipmi.c b/src/mainboard/ocp/deltalake/ipmi.c index 9022215..25a5a27 100644 --- a/src/mainboard/ocp/deltalake/ipmi.c +++ b/src/mainboard/ocp/deltalake/ipmi.c @@ -5,7 +5,6 @@ #include <drivers/ipmi/ipmi_ops.h> #include <drivers/ipmi/ocp/ipmi_ocp.h> #include <drivers/vpd/vpd.h> -#include <string.h>
#include "ipmi.h" #include "vpd.h" diff --git a/src/mainboard/ocp/deltalake/loglevel_vpd.c b/src/mainboard/ocp/deltalake/loglevel_vpd.c index 7880879..aa85cb9 100644 --- a/src/mainboard/ocp/deltalake/loglevel_vpd.c +++ b/src/mainboard/ocp/deltalake/loglevel_vpd.c @@ -2,7 +2,6 @@
#include <console/console.h> #include <drivers/vpd/vpd.h> -#include <string.h>
#include "vpd.h"
diff --git a/src/mainboard/ocp/deltalake/romstage.c b/src/mainboard/ocp/deltalake/romstage.c index 0a7ecf1..f833715 100644 --- a/src/mainboard/ocp/deltalake/romstage.c +++ b/src/mainboard/ocp/deltalake/romstage.c @@ -7,7 +7,6 @@ #include <fsp/api.h> #include <FspmUpd.h> #include <soc/romstage.h> -#include <string.h>
#include "chip.h" #include "ipmi.h" diff --git a/src/mainboard/prodrive/hermes/mainboard.c b/src/mainboard/prodrive/hermes/mainboard.c index d9abb76..a5cf887 100644 --- a/src/mainboard/prodrive/hermes/mainboard.c +++ b/src/mainboard/prodrive/hermes/mainboard.c @@ -3,7 +3,6 @@ #include <acpi/acpigen.h> #include <device/device.h> #include <intelblocks/pmclib.h> -#include <string.h> #include <types.h> #include "variants/baseboard/include/eeprom.h" #include "gpio.h" diff --git a/src/mainboard/protectli/vault_bsw/acpi_tables.c b/src/mainboard/protectli/vault_bsw/acpi_tables.c index 6fc71fe..87a1c40 100644 --- a/src/mainboard/protectli/vault_bsw/acpi_tables.c +++ b/src/mainboard/protectli/vault_bsw/acpi_tables.c @@ -4,7 +4,6 @@ #include <arch/ioapic.h> #include <soc/acpi.h> #include <soc/nvs.h> -#include <string.h>
void mainboard_fill_gnvs(struct global_nvs *gnvs) { diff --git a/src/northbridge/intel/haswell/gma.c b/src/northbridge/intel/haswell/gma.c index e69cfec..94b6075 100644 --- a/src/northbridge/intel/haswell/gma.c +++ b/src/northbridge/intel/haswell/gma.c @@ -16,7 +16,6 @@ #include <cpu/intel/haswell/haswell.h> #include <drivers/intel/gma/opregion.h> #include <southbridge/intel/lynxpoint/pch.h> -#include <string.h> #include <types.h>
#include "chip.h" diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index 2c16818..7bfddde 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -4,7 +4,6 @@ #include <commonlib/helpers.h> #include <console/console.h> #include <cpu/intel/model_206ax/model_206ax.h> -#include <string.h> #include <device/mmio.h> #include <device/pci_ops.h> #include <northbridge/intel/sandybridge/chip.h> diff --git a/src/security/intel/txt/logging.c b/src/security/intel/txt/logging.c index 7d8dcf7..683247d 100644 --- a/src/security/intel/txt/logging.c +++ b/src/security/intel/txt/logging.c @@ -3,7 +3,6 @@ #include <arch/mmio.h> #include <console/console.h> #include <cpu/x86/smm.h> -#include <string.h> #include <types.h>
#include "txt.h" diff --git a/src/soc/amd/picasso/acpi.c b/src/soc/amd/picasso/acpi.c index 2f08dce..357dfce 100644 --- a/src/soc/amd/picasso/acpi.c +++ b/src/soc/amd/picasso/acpi.c @@ -4,7 +4,6 @@ * ACPI - create the Fixed ACPI Description Tables (FADT) */
-#include <string.h> #include <console/console.h> #include <acpi/acpi.h> #include <acpi/acpi_gnvs.h> diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c index af3bf12..8e1f600 100644 --- a/src/soc/amd/stoneyridge/acpi.c +++ b/src/soc/amd/stoneyridge/acpi.c @@ -4,7 +4,6 @@ * ACPI - create the Fixed ACPI Description Tables (FADT) */
-#include <string.h> #include <console/console.h> #include <acpi/acpi.h> #include <acpi/acpi_gnvs.h> diff --git a/src/soc/intel/alderlake/bootblock/report_platform.c b/src/soc/intel/alderlake/bootblock/report_platform.c index 002b306..e3646e0 100644 --- a/src/soc/intel/alderlake/bootblock/report_platform.c +++ b/src/soc/intel/alderlake/bootblock/report_platform.c @@ -17,7 +17,6 @@ #include <intelblocks/mp_init.h> #include <soc/bootblock.h> #include <soc/pci_devs.h> -#include <string.h>
static struct { u32 cpuid; diff --git a/src/soc/intel/apollolake/acpi.c b/src/soc/intel/apollolake/acpi.c index 2c271d2..555d2f6 100644 --- a/src/soc/intel/apollolake/acpi.c +++ b/src/soc/intel/apollolake/acpi.c @@ -19,7 +19,6 @@ #include <soc/nvs.h> #include <soc/pci_devs.h> #include <soc/systemagent.h> -#include <string.h>
#include "chip.h"
diff --git a/src/soc/intel/baytrail/ramstage.c b/src/soc/intel/baytrail/ramstage.c index f1401e2..6e973ff 100644 --- a/src/soc/intel/baytrail/ramstage.c +++ b/src/soc/intel/baytrail/ramstage.c @@ -12,7 +12,6 @@ #include <device/device.h> #include <device/pci_def.h> #include <device/pci_ops.h> -#include <string.h>
#include <soc/gpio.h> #include <soc/lpc.h> diff --git a/src/soc/intel/baytrail/southcluster.c b/src/soc/intel/baytrail/southcluster.c index e4c2bf0..033cd47 100644 --- a/src/soc/intel/baytrail/southcluster.c +++ b/src/soc/intel/baytrail/southcluster.c @@ -12,7 +12,6 @@ #include <device/pci_ids.h> #include <pc80/mc146818rtc.h> #include <drivers/uart/uart8250reg.h> -#include <string.h>
#include <soc/iomap.h> #include <soc/irq.h> diff --git a/src/soc/intel/braswell/ramstage.c b/src/soc/intel/braswell/ramstage.c index e59f3eb..48f2193 100644 --- a/src/soc/intel/braswell/ramstage.c +++ b/src/soc/intel/braswell/ramstage.c @@ -19,7 +19,6 @@ #include <soc/pci_devs.h> #include <soc/pm.h> #include <soc/ramstage.h> -#include <string.h>
#define SHOW_PATTRS 1
diff --git a/src/soc/intel/broadwell/acpi.c b/src/soc/intel/broadwell/acpi.c index 5546f27..66bc058 100644 --- a/src/soc/intel/broadwell/acpi.c +++ b/src/soc/intel/broadwell/acpi.c @@ -8,7 +8,6 @@ #include <device/pci_ops.h> #include <console/console.h> #include <types.h> -#include <string.h> #include <cpu/x86/msr.h> #include <cpu/intel/turbo.h> #include <soc/acpi.h> diff --git a/src/soc/intel/broadwell/pch/lpc.c b/src/soc/intel/broadwell/pch/lpc.c index 84b8d00..1e866f9 100644 --- a/src/soc/intel/broadwell/pch/lpc.c +++ b/src/soc/intel/broadwell/pch/lpc.c @@ -12,7 +12,6 @@ #include <acpi/acpi.h> #include <acpi/acpi_gnvs.h> #include <cpu/x86/smm.h> -#include <string.h> #include <soc/gpio.h> #include <soc/iobp.h> #include <soc/iomap.h> diff --git a/src/soc/intel/broadwell/pch/ramstage.c b/src/soc/intel/broadwell/pch/ramstage.c index a75bd36..4b8e93f 100644 --- a/src/soc/intel/broadwell/pch/ramstage.c +++ b/src/soc/intel/broadwell/pch/ramstage.c @@ -6,7 +6,6 @@ #include <bootstate.h> #include <console/console.h> #include <device/device.h> -#include <string.h> #include <soc/nvs.h> #include <soc/pm.h> #include <soc/intel/broadwell/chip.h> diff --git a/src/soc/intel/common/block/acpi/acpi.c b/src/soc/intel/common/block/acpi/acpi.c index e7f3f0d..cf62ccc 100644 --- a/src/soc/intel/common/block/acpi/acpi.c +++ b/src/soc/intel/common/block/acpi/acpi.c @@ -19,7 +19,6 @@ #include <soc/gpio.h> #include <soc/iomap.h> #include <soc/pm.h> -#include <string.h>
#define CPUID_6_EAX_ISST (1 << 7)
diff --git a/src/soc/intel/elkhartlake/bootblock/report_platform.c b/src/soc/intel/elkhartlake/bootblock/report_platform.c index b1b7fe8..1dd3197 100644 --- a/src/soc/intel/elkhartlake/bootblock/report_platform.c +++ b/src/soc/intel/elkhartlake/bootblock/report_platform.c @@ -12,7 +12,6 @@ #include <soc/bootblock.h> #include <soc/pch.h> #include <soc/pci_devs.h> -#include <string.h>
static struct { uint32_t cpuid; diff --git a/src/soc/intel/elkhartlake/fsp_params.c b/src/soc/intel/elkhartlake/fsp_params.c index 3aed1ac..3ef3b5d 100644 --- a/src/soc/intel/elkhartlake/fsp_params.c +++ b/src/soc/intel/elkhartlake/fsp_params.c @@ -13,7 +13,6 @@ #include <soc/pci_devs.h> #include <soc/ramstage.h> #include <soc/soc_chip.h> -#include <string.h>
/* * ME End of Post configuration diff --git a/src/soc/intel/elkhartlake/romstage/fsp_params.c b/src/soc/intel/elkhartlake/romstage/fsp_params.c index f6c59a6..464e1d4 100644 --- a/src/soc/intel/elkhartlake/romstage/fsp_params.c +++ b/src/soc/intel/elkhartlake/romstage/fsp_params.c @@ -6,7 +6,6 @@ #include <soc/pci_devs.h> #include <soc/romstage.h> #include <soc/soc_chip.h> -#include <string.h>
static void soc_memory_init_params(FSP_M_CONFIG *m_cfg, const struct soc_intel_elkhartlake_config *config) diff --git a/src/soc/intel/jasperlake/bootblock/report_platform.c b/src/soc/intel/jasperlake/bootblock/report_platform.c index beab782..a588b75 100644 --- a/src/soc/intel/jasperlake/bootblock/report_platform.c +++ b/src/soc/intel/jasperlake/bootblock/report_platform.c @@ -12,7 +12,6 @@ #include <soc/bootblock.h> #include <soc/pch.h> #include <soc/pci_devs.h> -#include <string.h>
static struct { u32 cpuid; diff --git a/src/soc/intel/xeon_sp/acpi.c b/src/soc/intel/xeon_sp/acpi.c index 5e5267d..9da1b14 100644 --- a/src/soc/intel/xeon_sp/acpi.c +++ b/src/soc/intel/xeon_sp/acpi.c @@ -4,7 +4,6 @@ #include <intelblocks/acpi.h> #include <soc/pci_devs.h> #include <soc/util.h> -#include <string.h>
#include "chip.h"
diff --git a/src/soc/intel/xeon_sp/cpx/soc_util.c b/src/soc/intel/xeon_sp/cpx/soc_util.c index 280bedc..7a8403e 100644 --- a/src/soc/intel/xeon_sp/cpx/soc_util.c +++ b/src/soc/intel/xeon_sp/cpx/soc_util.c @@ -9,7 +9,6 @@ #include <soc/soc_util.h> #include <soc/util.h> #include <stdlib.h> -#include <string.h>
const struct SystemMemoryMapHob *get_system_memory_map(void) { diff --git a/src/soc/mediatek/mt8192/dramc_pi_basic_api.c b/src/soc/mediatek/mt8192/dramc_pi_basic_api.c index af1410b..996dff8 100644 --- a/src/soc/mediatek/mt8192/dramc_pi_basic_api.c +++ b/src/soc/mediatek/mt8192/dramc_pi_basic_api.c @@ -4,7 +4,6 @@ #include <soc/dramc_pi_api.h> #include <soc/dramc_register.h> #include <soc/gpio.h> -#include <string.h> #include <timer.h>
static const u8 mrr_o1_pinmux_mapping[PINMUX_MAX][CHANNEL_MAX][DQ_DATA_WIDTH] = { diff --git a/src/soc/mediatek/mt8192/dramc_pi_calibration_api.c b/src/soc/mediatek/mt8192/dramc_pi_calibration_api.c index e4dc896..5c6d94d 100644 --- a/src/soc/mediatek/mt8192/dramc_pi_calibration_api.c +++ b/src/soc/mediatek/mt8192/dramc_pi_calibration_api.c @@ -2,7 +2,6 @@
#include <soc/dramc_pi_api.h> #include <soc/dramc_register.h> -#include <string.h>
static const u8 imp_vref_sel[ODT_MAX][IMP_DRV_MAX] = { /* DRVP DRVN ODTP ODTN */ diff --git a/src/soc/mediatek/mt8192/pmif.c b/src/soc/mediatek/mt8192/pmif.c index 57fc9d4..a7ab4e5 100644 --- a/src/soc/mediatek/mt8192/pmif.c +++ b/src/soc/mediatek/mt8192/pmif.c @@ -9,7 +9,6 @@ #include <soc/pmif_spmi.h> #include <soc/pmif_sw.h> #include <soc/spmi.h> -#include <string.h> #include <timer.h>
static int pmif_check_swinf(struct pmif *arb, long timeout_us, u32 expected_status) diff --git a/src/soc/mediatek/mt8192/pmif_spmi.c b/src/soc/mediatek/mt8192/pmif_spmi.c index 87b003b..f30e965 100644 --- a/src/soc/mediatek/mt8192/pmif_spmi.c +++ b/src/soc/mediatek/mt8192/pmif_spmi.c @@ -9,7 +9,6 @@ #include <soc/pmif_spmi.h> #include <soc/pmif_sw.h> #include <soc/spmi.h> -#include <string.h>
#define PMIF_CMD_PER_3 (0x1 << PMIF_CMD_EXT_REG_LONG) #define PMIF_CMD_PER_1_3 ((0x1 << PMIF_CMD_REG) | (0x1 << PMIF_CMD_EXT_REG_LONG)) diff --git a/src/soc/qualcomm/sc7180/carve_out.c b/src/soc/qualcomm/sc7180/carve_out.c index 960b923..604abbd 100644 --- a/src/soc/qualcomm/sc7180/carve_out.c +++ b/src/soc/qualcomm/sc7180/carve_out.c @@ -4,7 +4,6 @@ #include <soc/mmu_common.h> #include <soc/symbols.h> #include <device/mmio.h> -#include <string.h>
#define MODEM_ID_LTE 0x004c5445 #define MODEM_ID_WIFI 0x57494649 diff --git a/src/soc/qualcomm/sc7180/display/dsi_phy_pll.c b/src/soc/qualcomm/sc7180/display/dsi_phy_pll.c index 88754ee..0e7f387 100644 --- a/src/soc/qualcomm/sc7180/display/dsi_phy_pll.c +++ b/src/soc/qualcomm/sc7180/display/dsi_phy_pll.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <device/mmio.h> -#include <string.h> #include <stdint.h> #include <delay.h> #include <edid.h> diff --git a/src/southbridge/intel/i82801gx/lpc.c b/src/southbridge/intel/i82801gx/lpc.c index a8bc7e3..7a6df04 100644 --- a/src/southbridge/intel/i82801gx/lpc.c +++ b/src/southbridge/intel/i82801gx/lpc.c @@ -15,7 +15,6 @@ #include <cpu/x86/smm.h> #include <acpi/acpigen.h> #include <arch/smp/mpspec.h> -#include <string.h> #include <southbridge/intel/common/acpi_pirq_gen.h> #include <southbridge/intel/common/hpet.h> #include <southbridge/intel/common/pmbase.h> diff --git a/src/southbridge/intel/i82801ix/lpc.c b/src/southbridge/intel/i82801ix/lpc.c index ed1ced6..25a4069 100644 --- a/src/southbridge/intel/i82801ix/lpc.c +++ b/src/southbridge/intel/i82801ix/lpc.c @@ -14,7 +14,6 @@ #include <acpi/acpi.h> #include <cpu/x86/smm.h> #include <acpi/acpigen.h> -#include <string.h> #include "chip.h" #include "i82801ix.h" #include <southbridge/intel/common/pciehp.h> diff --git a/src/southbridge/intel/i82801jx/lpc.c b/src/southbridge/intel/i82801jx/lpc.c index a279834..cb80cae 100644 --- a/src/southbridge/intel/i82801jx/lpc.c +++ b/src/southbridge/intel/i82801jx/lpc.c @@ -15,7 +15,6 @@ #include <cpu/x86/smm.h> #include <acpi/acpigen.h> #include <arch/smp/mpspec.h> -#include <string.h> #include "chip.h" #include "i82801jx.h" #include <southbridge/intel/common/pciehp.h> diff --git a/src/southbridge/intel/ibexpeak/lpc.c b/src/southbridge/intel/ibexpeak/lpc.c index 361d3a9..ca2986f 100644 --- a/src/southbridge/intel/ibexpeak/lpc.c +++ b/src/southbridge/intel/ibexpeak/lpc.c @@ -15,7 +15,6 @@ #include <acpi/acpi.h> #include <elog.h> #include <acpi/acpigen.h> -#include <string.h> #include <cpu/x86/smm.h> #include "chip.h" #include "pch.h" diff --git a/src/southbridge/intel/lynxpoint/lpc.c b/src/southbridge/intel/lynxpoint/lpc.c index b0ff545..7e6799c 100644 --- a/src/southbridge/intel/lynxpoint/lpc.c +++ b/src/southbridge/intel/lynxpoint/lpc.c @@ -12,7 +12,6 @@ #include <arch/ioapic.h> #include <acpi/acpi.h> #include <cpu/x86/smm.h> -#include <string.h> #include "chip.h" #include "iobp.h" #include "pch.h"