Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33142 )
Change subject: Kconfig: Create coreboot separate stage kconfigs ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/33142/1/src/Kconfig File src/Kconfig:
https://review.coreboot.org/#/c/33142/1/src/Kconfig@21 PS1, Line 21: config STAGE_BOOTBLOCK Can we add ENABLE or PRESENT to these names? I feel like they read better when used.
https://review.coreboot.org/#/c/33142/1/src/Kconfig@23 PS1, Line 23: default y if ARCH_BOOTBLOCK_PPC64 || ARCH_BOOTBLOCK_ARMV8_64 || ARCH_BOOTBLOCK_ARM64 || ARCH_BOOTBLOCK_ARMV7 || ARCH_BOOTBLOCK_ARMV7_M || ARCH_BOOTBLOCK_ARMV7_R || ARCH_BOOTBLOCK_ARM || ARCH_BOOTBLOCK_ARMV4 || ARCH_BOOTBLOCK_RISCV || ARCH_BOOTBLOCK_X86_32 || ARCH_BOOTBLOCK_X86_64 || ARCH_BOOTBLOCK_MIPS Would it be better to select this config from these Kconfig locations and have this one default to n? The reason I say that is someone will have to know to modify this option when adding a new arch where my suggestion people would see the 'select' line when using an existing arch as a guide. The options are tightly coupled and leaves less room for error.