build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30917 )
Change subject: soc/intel/cannonlake: Change in SaGv options
......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/#/c/30917/5/src/soc/intel/cannonlake/chip.h
File src/soc/intel/cannonlake/chip.h:
https://review.coreboot.org/#/c/30917/5/src/soc/intel/cannonlake/chip.h@103
PS5, Line 103: * When enabled memory will be training at two or three different frequencies.
line over 80 characters
https://review.coreboot.org/#/c/30917/5/src/soc/intel/cannonlake/chip.h@104
PS5, Line 104: * for CNL options are as following
trailing whitespace
https://review.coreboot.org/#/c/30917/5/src/soc/intel/cannonlake/chip.h@105
PS5, Line 105: * 0:Disabled, 1:FixedLow, 2:FixedMid, 3:FixedHigh, 4:Enabled
trailing whitespace
https://review.coreboot.org/#/c/30917/5/src/soc/intel/cannonlake/chip.h@106
PS5, Line 106: * for others options are as following
trailing whitespace
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30917
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I754515c2f8e249479c603872c61ac9a006e962ff
Gerrit-Change-Number: 30917
Gerrit-PatchSet: 5
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Lijian Zhao
lijian.zhao@intel.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Tue, 15 Jan 2019 05:05:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment