Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40593 )
Change subject: soc/intel/apollolake: Hook up GMA ACPI brightness controls
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40593/5/src/soc/intel/apollolake/ch...
File src/soc/intel/apollolake/chip.h:
https://review.coreboot.org/c/coreboot/+/40593/5/src/soc/intel/apollolake/ch...
PS5, Line 192: struct i915_gpu_controller_info gfx;
Why not place this next to panel_cfg?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40593
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia62a88b58e7efd90f550000fc5b2cef0cb5fade7
Gerrit-Change-Number: 40593
Gerrit-PatchSet: 5
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 31 Dec 2020 23:41:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment