Attention is currently required from: Tarun Tuli, Eran Mitrani, Subrata Banik, Kapil Porwal, Dinesh Gehlot.
Hello build bot (Jenkins), Tarun Tuli, Eran Mitrani, Subrata Banik, Dinesh Gehlot,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/73278
to look at the new patch set (#3).
Change subject: drivers/soundwire/max98363: Support MAX98363 SoundWire device ......................................................................
drivers/soundwire/max98363: Support MAX98363 SoundWire device
The MAX98363 smart speaker amp can be connected over SoundWire and be configured for mainboards to use:
- Data Port 0 and Bulk Register Access is not supported - Data Port 1 is the 32bit data input for the speaker path
The data port and audio mode properties are filled out as best as possible with the datasheet as a reference.
The ACPI address for the codec is calculated with the information in the codec driver combined with the devicetree.cb hierarchy where the link and unique IDs are extracted from the device path.
For example this device is connected to master link ID 2 and has strap settings configuring it for unique ID 0.
chip drivers/soundwire/max98363 register "desc" = ""Left Speaker Amp"" device generic 2.0 on end end
This driver was tested with the rex0 reference design by booting and disassembling the runtime SSDT to ensure that the devices have the expected address and properties.
Device (SW20) { Name (_ADR, 0x000230019F836300) // _ADR: Address Name (_DDN, "Left Speaker Amp") // _DDN: DOS Device Name Method (_STA, 0, NotSerialized) // _STA: Status { Return (0x0F) }
Name (_DSD, Package () { ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () { Package () { "mipi-sdw-sw-interface-revision", 0x00010000 }, [...] Package () { "mipi-sdw-source-port-list", Zero }, Package () { "mipi-sdw-sink-port-list", 0x02 } },
ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), Package () { Package () { "mipi-sdw-port-audio-mode-0", "MOD0" }, Package () { "mipi-sdw-dp-1-sink-subproperties", "SNK1" } } }) Name (MOD0, Package () { ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () { Package () { "mipi-sdw-audio-mode-bus-frequency-configs", Package () { 0x00927C00, ... } }, Package () { "mipi-sdw-audio-mode-sampling-frequency-configs", Package () { 0x3E80, ... } }, [...] } }) Name (SNK1, Package () { ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () { Package () { "mipi-sdw-data-port-type", Zero }, [...] },
ToUUID ("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), Package () { Package () { "mipi-sdw-port-audio-mode-0", "MOD0" } } }) }
BUG=b:269497731 TEST=Verified SSDT for SNDW in the OS
Signed-off-by: Kapil Porwal kapilporwal@google.com Change-Id: Ie56109d615759e3e5e32782c8782cb2f47014ec4 --- A src/drivers/soundwire/max98363/Kconfig A src/drivers/soundwire/max98363/Makefile.inc A src/drivers/soundwire/max98363/chip.h A src/drivers/soundwire/max98363/max98363.c M src/include/mipi/ids.h 5 files changed, 254 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/73278/3