Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45206 )
Change subject: herobrine : Provide initial mainboard support ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45206/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45206/2//COMMIT_MSG@7 PS2, Line 7: herobrine : Please remove the space before the colon.
https://review.coreboot.org/c/coreboot/+/45206/2//COMMIT_MSG@7 PS2, Line 7: herobrine : Provide initial mainboard support Please mention the SoC in the commit message.
https://review.coreboot.org/c/coreboot/+/45206/2//COMMIT_MSG@10 PS2, Line 10: Signed-off-by: Ravi One space is enough.