Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41279 )
Change subject: mb/ocp/deltalake: Populate SMBIOS data and set the read PPIN to BMC
......................................................................
Patch Set 11:
(3 comments)
https://review.coreboot.org/c/coreboot/+/41279/10/src/mainboard/ocp/deltalak...
File src/mainboard/ocp/deltalake/ipmi.h:
https://review.coreboot.org/c/coreboot/+/41279/10/src/mainboard/ocp/deltalak...
PS10, Line 2: /* This file is part of the coreboot project. */
please remove
Done
https://review.coreboot.org/c/coreboot/+/41279/10/src/mainboard/ocp/deltalak...
PS10, Line 6: #include <types.h>
please insert a line between "#define DELTALAKE_IPMI_H" and "#include... […]
Done
https://review.coreboot.org/c/coreboot/+/41279/10/src/mainboard/ocp/deltalak...
PS10, Line 6: #include <types.h>
This is OK. […]
Thanks for your suggestion, updated.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41279
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9127cf5da1c56d8012694d070615aec24cc22fdf
Gerrit-Change-Number: 41279
Gerrit-PatchSet: 11
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 01 Jun 2020 08:37:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment