Attention is currently required from: Kevin Chiu, Furquan Shaikh, Paul Menzel, Robert Chen, Tim Wawrzynczak, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57828 )
Change subject: mb/google/dedede/var/kracko: refactor DPTF section for overrides
......................................................................
Patch Set 10:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57828/comment/55030434_4b0f94a8
PS4, Line 12: None
tracker number?
Done
https://review.coreboot.org/c/coreboot/+/57828/comment/5cd76fd9_589382c4
PS4, Line 13: None
dedede
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/57828/comment/546f63d5_0f6f0885
PS6, Line 2: RobertChen
Robert Chen
Done
https://review.coreboot.org/c/coreboot/+/57828/comment/78dc4211_3541294c
PS6, Line 10: Because the DPTF tool's CRT, PSV and TSR3 settings are different than expected.
Please rephrase, as it’s only half a sentence.
Done
https://review.coreboot.org/c/coreboot/+/57828/comment/74ebb43b_4eda6534
PS6, Line 17: RobertChen
Ditto.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57828
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iacc543f961a7f4652ee8583920b1794f916c7ec9
Gerrit-Change-Number: 57828
Gerrit-PatchSet: 10
Gerrit-Owner: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 24 Sep 2021 17:54:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Chiu
kevin.chiu.17802@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment