Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47882 )
Change subject: util/cbfstool: Add support for mapping extended window for x86 platforms ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47882/8/util/cbfstool/cbfstool.c File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/47882/8/util/cbfstool/cbfstool.c@17... PS8, Line 171: 16 * MiB
this and the 4ULL*GiB (originally from the previous patch but could just be done in this one) might […]
Done
https://review.coreboot.org/c/coreboot/+/47882/8/util/cbfstool/cbfstool.c@18... PS8, Line 183: /*
this is all very helpful for understanding the implementation. […]
That is a good idea. I will create documents in follow up CLs to explain the cbfstool part as well as the Intel implementation part.