Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30913 )
Change subject: mainboard/intel: Update mainboard UART Kconfig ......................................................................
Patch Set 2:
Patch Set 2:
@Nico, you should consider to fix such problem rather causing huge sets of board not working and we need to spend lots of hour to make things correct. I'm not sure what problem ur supposed to fix by calling "Clean Up UART mess", i believe it will be more messier now with lots of if and else select to support a lots of board using variant model
Well, this "huge sets of board not working" was caused by two issues:
- Everybody was hiding board layout information (what pads are used for UART and which UART is used for debugging) in their private `.config`.
- Seemingly nobody invited to review did act to prevent the breakage in the past two months.
The original problem I fixed: You could potentially cause short-circuits on your mainboard by choosing the wrong settings in your `.config`. That seems like a very bad design, and I won't have it here on coreboot.org.
The story is not over, yet. There is still pad configuration done in the soc/ code based on Kconfig symbols (I only made sure that you are not prompted for them in Kconfig). This should move to mainboard/ code so we can get rid of INTEL_LPSS_UART_FOR_CONSOLE.
partial fixing of problem and leaving on others to act on accordingly always dangerous. I would recommend better to ask onwer to test and give their +2 before merge any common CL unless you have tested all board.
Please look at my this CL, i have tested few and requesting IOTG folks to try their boards.