HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30993 )
Change subject: nb/intel/i945: Don't rewrite R/WO RCBA registers ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/#/c/30993/6/src/northbridge/intel/i945/early_ini... File src/northbridge/intel/i945/early_init.c:
https://review.coreboot.org/#/c/30993/6/src/northbridge/intel/i945/early_ini... PS6, Line 349: : : : : : : here printk before and after the "write" shows that no thing happen. the "write" have no effect.
https://review.coreboot.org/#/c/30993/6/src/northbridge/intel/i945/early_ini... PS6, Line 371: : : : : : : : : : : : : here also, using printk, we can see that the "write" have no effect, as those registers are R/WO and we already write on them
https://review.coreboot.org/#/c/30993/6/src/northbridge/intel/i945/early_ini... PS6, Line 867: RCBA32(ESD) |= (2 << 16); : : RCBA32(ULD) |= (1 << 24) | (1 << 16); : : RCBA32(ULBA) = (uintptr_t)DEFAULT_DMIBAR; : /* Write ESD.CID to TCID */ : RCBA32(RP1D) |= (2 << 16); : RCBA32(RP2D) |= (2 << 16); : RCBA32(RP3D) |= (2 << 16); : RCBA32(RP4D) |= (2 << 16); : RCBA32(HDD) |= (2 << 16); : RCBA32(RP5D) |= (2 << 16); : RCBA32(RP6D) |= (2 << 16); here using printk, we can clearly see that we write on those registers