Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44375 )
Change subject: libpayload: cbgfx: Add color mapping functionality ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44375/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/c/coreboot/+/44375/2/payloads/libpayload/drivers... PS2, Line 220: fg_color - bg_color nit: Actually, one more optimization might be to do this calculation in set_color_map() already, so it doesn't have to be redone for every pixel. Maybe rename the globals color_map.base and color_map.scale or something like that then since they wouldn't be storing the plain foreground color anymore (just the difference to the background).