Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45078 )
Change subject: soc/intel/elkhartlake: Update Kconfig
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45078/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45078/4//COMMIT_MSG@10
PS4, Line 10: 1. use FSP2.1 instead of 2.2
Why? Isn’t it a newer platform?
https://review.coreboot.org/c/coreboot/+/45078/4//COMMIT_MSG@17
PS4, Line 17: 8. update UART base address
I’d prefer one commit for each item.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45078
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a44d357d71be706f402a6b2a4f2d4e7c0eeb4a9
Gerrit-Change-Number: 45078
Gerrit-PatchSet: 4
Gerrit-Owner: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 20 Nov 2020 13:14:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment