EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46868 )
Change subject: mb/google/octopus/var/fleex: Disable XHCI LFPS power management by sku ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46868/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/fleex/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46868/2/src/mainboard/google/octopu... PS2, Line 87: register "disable_xhci_lfps_pm" = "0"
Could we put this one with DisableComplianceMode below together since they are all related to xHCI?
Sure, fsps parameter should out of device domain. Move it here.
https://review.coreboot.org/c/coreboot/+/46868/2/src/mainboard/google/octopu... File src/mainboard/google/octopus/variants/fleex/variant.c:
https://review.coreboot.org/c/coreboot/+/46868/2/src/mainboard/google/octopu... PS2, Line 38: struct soc_intel_apollolake_config *cfg = NULL;
A new line below this one at least for improving the reading.
Agree.
https://review.coreboot.org/c/coreboot/+/46868/2/src/mainboard/google/octopu... PS2, Line 41: if (is_lte_sku())
combine this condition into line 40?
Looks like we can update it anyway.