Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46144 )
Change subject: drivers/i2c/gpiomux: Add chip driver for multiplexed I2C bus ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46144/1/src/drivers/i2c/gpiomux/bus... File src/drivers/i2c/gpiomux/bus/bus.c:
https://review.coreboot.org/c/coreboot/+/46144/1/src/drivers/i2c/gpiomux/bus... PS1, Line 14: dev->chip_info config_of(dev)?
https://review.coreboot.org/c/coreboot/+/46144/1/src/drivers/i2c/gpiomux/bus... PS1, Line 22: name[ACPI_NAME_BUFFER_SIZE - 1] = '\0'; snprintf() already takes care of doing this.
https://review.coreboot.org/c/coreboot/+/46144/1/src/drivers/i2c/gpiomux/bus... PS1, Line 60: if (!config) : return; : I don't understand the intent of this check.