Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47308 )
Change subject: mb/google/zork: Init fingerprint GPIOs for boot vs resume ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47308/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47308/4//COMMIT_MSG@10 PS4, Line 10: This allows initialization of the : fingerprint GPIOs which need to be handled differently between wake : from S3 and boot from S5. What are these requirements? Can you please capture those in the commit message?
https://review.coreboot.org/c/coreboot/+/47308/4/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c:
https://review.coreboot.org/c/coreboot/+/47308/4/src/mainboard/google/zork/v... PS4, Line 300: gpio_fingerprint_poweron_table From this change, it looks like the fingerprint power is kept off and reset is asserted on boot-up. What enables the power to fingerprint? I don't see that happening in this CL.
Also, it is not clear what the requirements are. Do the GPIOs need to be driven low and then driven high in case on non-S3 boot whereas keep them driven high in case of S3 resume?