Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41884 )
Change subject: drivers/intel/dptf: Add current participant Devices to DSDT ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41884/8/src/drivers/intel/dptf/dptf... File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/41884/8/src/drivers/intel/dptf/dptf... PS8, Line 77: acpigen_emit_eisaid("INT3400");
I've been trying to decide whether or not to backport this to older platforms, so that we could comp […]
It seems new ACPI Device IDs for an exmaple INTC10xx are for Tiger Lake platform only AFAIK. We might need support for both INT34xx (7-character EISA format) and INTC10xx (8-character EISA format).
https://review.coreboot.org/c/coreboot/+/41884/11/src/drivers/intel/dptf/dpt... File src/drivers/intel/dptf/dptf.c:
https://review.coreboot.org/c/coreboot/+/41884/11/src/drivers/intel/dptf/dpt... PS11, Line 27: #define DPTF_DPTF_DEVICE_HID "INTC1040" These new ACPI Device IDs "INTC10xx" are being used for only TigerLake AFAIK at this point. In this case what about the old 7-char ESID ?
Also, can we move these defines and enums in dptf.h header file if possible. I did not go through complete series of these patches, if its already done. Thanks.