Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38514 )
Change subject: soc/intel/skylake: Update 64 bit SA DRAM bit fields as per SKL EDS
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38514/2/src/soc/intel/skylake/acpi/...
File src/soc/intel/skylake/acpi/systemagent.asl:
https://review.coreboot.org/c/coreboot/+/38514/2/src/soc/intel/skylake/acpi/...
PS2, Line 46: 28
The datasheet (doc 332688) says that bits 27 and 26 are either part of the PCIEXBAR field or part of […]
i will modify this patchset and https://review.coreboot.org/c/coreboot/+/38456 as well, it should start from 26bit as value of LENGTH also matter in total base calculation
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38514
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia32723444c044572fbcecce151d89e739e570b3b
Gerrit-Change-Number: 38514
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 23 Jan 2020 13:02:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment