Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47585 )
Change subject: intel/socket_441: Increase bootblock size
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47585/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/47585/1//COMMIT_MSG@7
PS1, Line 7: d945gclf
TianoCore is usually over 512 KiB, so it didn't really fit to begin with. […]
Right, sorry, I meant 0x8000, not 8K. Done.
https://review.coreboot.org/c/coreboot/+/47585/1//COMMIT_MSG@7
PS1, Line 7: intel/d945gclf: Disable bootblock console.
Nit: Please remove the dot/period at the end.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47585
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I620c13eab53c3326a4f4660b63ed1dd0fc81f563
Gerrit-Change-Number: 47585
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 17 Nov 2020 23:11:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment